Stock span(hackers block)

#1

i am not able to pass any testcases of this problem

#2

https://ide.codingblocks.com/s/107347 - this is the url of the code

#3

Hello @Ayushi21,

There are multiple issues with your code:

  1. The input format is wrong.
    You are not taking any input.
    You are just passing the same array and value of n for all testcases.

  2. How are you so sure that there would not be more than 6 elements in the array:
    void stockSpan(int arr[6], int n)
    Solution:
    void stockSpan(int arr[], int n)

  3. Your output format is also wrong.
    0 0 0 1 0 END
    You are not required to print END at last.
    Solution:
    Read the question carefully.

  4. Please review your logic as it will print 0 for the first element always.
    Thus, the other values would get effected.
    in span we have to consider elements which are equal and less.
    So, for the first element it should be 1 as we are considering current element and all elements before it.

Do you want me to explain the correct logic?

#4

umm yes it would be of great help.

#5

To understand this better, observe the following figure carefully:
image

Observations:

  1. The stock of any day is the count of consecutive days before (i+1)th day having values less and equal to the price at ith day, but before the first value on left that is greater than ith day’s price.
  2. The stock of first day is always one.

Refer to the following function:

Hope, this would help.
Give a like, if you are satisfied.

#6

https://ide.codingblocks.com/s/110150 - hey this is the url of the code but this code still is not working

#7

Hello @Ayushi21,

  1. You have not followed the point 3 of my previous reply:
    cout<<“END”<<endl;
    Why are you printing this? Is it mentioned in the question? Please check.

  2. How can you access an index of a non- array variable?
    int price = arr[i];
    price[st.top()]
    How is it possible?

It would work properly, once you would correct the above mentioned mistakes.
Refer the code, i have shared.

Hope, this would help.

#8

hey can you explain what do you mean by print S like what do i have to print

#9

https://ide.codingblocks.com/s/116366 - btw thias is my code . please tell me where i have to make corrections.

#10

Hello @Ayushi21,

You have missed the most important part of the problem:

  1. TAKING INPUTS
    Input Format:
    First line contains the number of test cases, T. For each test case, first line contains a single integer N, denoting the number of days. Next line contains N integers, ith of which denotes the stock’s price on ith day.

  2. 1<=N<=10^5
    Why are you taking the size of array as 6?

  3. Why are you printing END

I have corrected your code, check it here:

Hope, this would help.
Give a like, if you are satisfied.

#11

I hope I’ve cleared your doubt. I ask you to please rate your experience here
Your feedback is very important. It helps us improve our platform and hence provide you
the learning experience you deserve.

On the off chance, you still have some questions or not find the answers satisfactory, you may reopen
the doubt.