Segmentation fault

#1

while executing the code i am getting a segmentation fault error in c++(sublime text)

#2

Hey @pradyumn25jain
Can you post your code?

#3

sorry…never mind i figured it out :slight_smile:

1 Like
#4

int main()
{

int n=0;
cout<<"enter array elemnets"<<endl;
cin>>n;
int arr[n] = {0};
for(int i=0;i<n;i++){
	cin>>arr[i];
}
subarray(arr,n);

return 0;

}

#5

it kind of didnt worked …have a look

#6

@pradyumn25jain
post the code of subarray function.

#7

void subarray(int arr[],int n){
int sum = INT_MIN;
int left = 0;
int right = 0;
for(int i=0;i<n;i++){
for(int j=i+1;i<n;j++){
int cur_sum=0;
for(int k=i;k<j;k++){
cur_sum =+ arr[k];
}
if(cur_sum>sum){
sum =cur_sum;
left = i;
right = j;
}
}
}
for(int i=left;i<right+1;i++){
cout<<arr[i]<<" ";
}
cout<<endl<<“max sum is”<<sum;
}

#8

@pradyumn25jain
so it’s giving you the wrong ans?

#9

its giving me a segmentation fault during run time

#10

@pradyumn25jain

you’ve written i < n instead of j < n, see i’ll highlight with bold-italic
You need to write
for(int i=0;i<n;i++){
for(int j=i+1;j<n;j++){

1 Like
#11

yeah thank u so much …

1 Like
#12

@pradyumn25jain
Great great!
Can you mark the doubt as resolved if you’ve got it now.

1 Like
#13

i already did marked it as resolved

1 Like