Review my quiz app with django

atufashireen · April 1, 2021, 4:41pm

hi sir,
i am trying to implement a profile view(or profile page) in the app. The author should be able to update his content as well as see his created and attempted quizzes,where as a nonauthor (a user who is not author) shouldn’t be able to but see all the author’s content.
Jatin sir used mixins for creating profiles,but my code works fine too. Can u plz point if it is correct approach?(under users/views.py and users/templates/users/profile.html)
and if it not then plz point out the threats.

here is the link to code.

github.com

AtufaShireen/QuizCreator/blob/master/users/views.py

from django.shortcuts import render, redirect
from django.contrib import messages
from .forms import ProfileUpdateForm, UserUpdateForm, UserRegsitrationForm
from django.contrib.auth.decorators import login_required
from quiz.models import Quizzer,QuizScore

# Create your views here.
def register(request):
    if request.method == 'POST':
        form = UserRegsitrationForm(request.POST)
        if form.is_valid():
            form.save()
            username = form.cleaned_data.get('username')
            messages.success(request, f'Welcome {username}')
            return redirect('profile')  # change to blog-home
    else:
        form = UserRegsitrationForm()
    return render(request, 'users/register.html', {'form': form})

This file has been truncated. show original

A17LP0026 · April 1, 2021, 6:41pm

Hello @atufashireen, yes bro your code is absolutely correct but mixins is in-built functionality and some developers try to minimize the efforts and try to use as much functionality as provided by the code as because they provide the optimized way but there is nothing wrong trying your own implementations. I must say just practice as much as you can and try to learn different approaches as well, you may stick to only one approach but learning different styles will improve your skills and teach you a lot in the long run.
Happy coding
Thanks