Histogram Stack Problem

#1

I am getting error in this, please help me debug

#2

@Tapan
Change line 19 to while (!s.empty() && arr[s.top()] > x )

#3

It worked. This seems like a conceptual error, can you explain how both aren’t the same?

#4

I am still failing all test cases. Please help

#5

@Tapan
there is difference between (!s.empty() && arr[s.top()] > x ) and ( arr[s.top()] > x && !s.empty())
see program execute every statement from left to right. So in first case, first !s.empty() execute if it is false, whole condition become false and our program don’t check second condition i.e arr[s.top()]>x.
But in second case, first arr[s.stop()] execute which gave segmentation fault if our s queue is empty(i.e we don’t have s.top() )

#6

@Tapan
I think you got 100 points. Please mark this doubt as resolved.