Histogram area problem

#1

my code is giving segmentation error when i try to submit it on gfg


please help

#2

Hey @gulatigarvita08
Please share the link where u are submitting it :slight_smile:

#3

https://practice.geeksforgeeks.org/problems/maximum-rectangular-area-in-a-histogram-1587115620/1#

#4

Hey @gulatigarvita08
I think u shared the incomplete code , because long getMaxArea(long long arr[], int n) function is missing in it,please reshare the complete code :slight_smile:

#5

oh sorry :sweat_smile:

#6

Hey @gulatigarvita08
Mentioned the changes in comments : https://ide.codingblocks.com/s/370880 :slight_smile:

You are getting segmentation because of static allocation
Max size arrays u can create inside function statically is close to 10^6 so sometimes it gives segmentation

#7

but 1<=n<=10^6
so why long long

#8

n is array size but array elements can be of order 10^18 that is why long long

#9

that array i took as long long
but lb and rb are just storing idexes … so ig it can have static allocation

#10

Oh yes ,sorry u can use int for them :sweat_smile:

#11

but then why my code is giving segmentation error :sweat_smile:

#12

Irrespective of int array or long long array

#13

sorry could’nt understand :sweat_smile:
when do we statically allocate ??

#14

int arr[n] // this is static allocation

int*arr=new int[n] //this is dynamic allocation

#15

i mean why are we dynamically allocating memory to it

#16

I just told u that maximum size arrays u can create inside any function is 10^6 when allocating them statically because of limited stack memory

So sometimes this gives segmentation error

To overcome this we allocate space dyanmically i.e from heap .

#17

but still the thing is we have 1<=n<=10^6 … so why dynamically

#18

assume n is 10^6
And u declare two arrays
int arr1[1000000]
int arr2[1000000] but here memory in stack was not available hence it will give segmentation error. thats why dynamically

#19

code is giving runtime error …

#20

Please share the code again :slight_smile: