Giving wrong ans :(

#1
#2

@Muskan-Gupta-598128740703036,
Wrong link…:slightly_frowning_face:

#3

pura code likha tha abhi , save bhi kiya …abh pta nhi kyu show nhi krra

#4
#5

second time, same wa

#6

@Muskan-Gupta-598128740703036,
Nope, still no code, please try saving it on any other online IDE, ideone maybe.

#7
#8

sir??? aapne code dekha??

#9

@Muskan-Gupta-598128740703036,
The l,r,x,y given in problem are 1 based indexed, but the array on which you build the tree is 0 based
buildTree(arr,0,n-1,tree,1); - > …0,n-1…

#10
#11

showing wrong ans on submission but given sample case is running perfect

#12

sir?? its showing wrong ans

#13

i am waiting for reply

#14

Hey @Muskan-Gupta-598128740703036,

Here is the correct code ( I have attached the ideone link as well incase cb ide does not show the code):

ERRORS:

  1. You need to initialize tree as -1.
  2. Use long everywhere possible.
  3. Instead of taking arr of size n+1 take it as n only and build tree from 0 to n-1 instead of 1 to n. Also input should be from 0 to n-1 instead of 1 to n as you had done.
  4. In the updatenode method, there was an error. You had written tree[index] += increment; which should be tree[index] = increment;

If you have any further queries kindly reply to this thread, I would be happy to help :smile: :blush:

#15

Thankyou sir , ho gya and samjh aa gya ! :slight_smile: