Fatal error: control may reach end of non-void function

#1

Next Greater Element II Leetcode

image
image1919×878 45.2 KB


Please help me to solve this kind of error…

#2

please share your code through ide.codingblocks.com

#3
#4

Sir,is this code visible to you through this link?

#5

Yes, the code is visible can you tell me the name of the question.

#6

Next Greater Element II Leetcode
my code is failing for similar elements.like second 1 in end returns -1
image

#7

you’ve unnecessarily made the code complex, you just need to iterate the array twice using stack and you would get answer.

#8

ohh.I will try implementing that.
Pr ab isko kaise theek kiya jaye. :sweat_smile:

#9

sir ? ? ???

#10

Sorry, the notification got messed up and I must’ve missed this one, can you explain the approach you are trying to use in order to solve this question

#11

image
Sir, i tried following this approach for finding next greatest element.
now since given array is circular array so if we didnot find required greater element in end then we have to traverse from start of the array again.for dealing with circular array i am trying this.please correct me if am doing it wrong.
image
image927×279 12 KB

ohho yeh to bda hogya. :sweat:

#12

instead of pushing the elements value inside the stack push the index of the element
Code

1 Like
#13

Ohh. Thank you sir :slight_smile:

#14

I hope I’ve cleared your doubt. I ask you to please rate your experience here
Your feedback is very important. It helps us improve our platform and hence provide you
the learning experience you deserve.

On the off chance, you still have some questions or not find the answers satisfactory, you may reopen
the doubt.