Doubt on using recursion logic

#1

Could you help me where I am going wrong with this logic?

#2

hello @PThak2018
ur logic looks correct to me.
can u pls share a running code so that i can check where it is failing(as i m not familiar with java)

#3


Getting stack overflow error. Some problem with base condition i guess that;s why it is giving this error.

#4

hello @PThak2018

image
image777×55 2.21 KB

this is the culprit for the same. here u are never incrementing ur index which is causing in infinite recursion.
remove this complete line because it will give same output as smalloutput1.

#5

Thanks Aman :slight_smile:

#6

Hi,
https://ide.codingblocks.com/s/250938.

Please go through the code. This is passing for all the test cases on coding blocks environment but ideally is should not.
I have used a test case in the above code where this is failing. May be we need to add more test cases to the problem in coding blocks IDE.
Also, if you can help without changing the logic?

#7

image
why u have commented this part,
this should be there in ur array so uncomment it in place of smalloutput2 use smalloutput1.

#8

Hi Aman,

image

Loop is there on smallOutput1. But this code is running for all test cases in Coding Blocks IDE and as shown previously, it is failing for one test cases. The test cases needs to be updated on Coding blocks IDE.

#9

no this loop is for including arr[index],
u need to add one more loop when for excluding arr[index].
and in that simply append smalloutput1 in output