Doubt in string generation acode

#1

Sir whats wrong in this code why is output wrong

#2

correct way to do is this
look at modified Code