Basic calculator code

#1


what is the problem with this code
some testcases are giving wrong answer

#2

#include
using namespace std;
int main() {

while(1)
{
	char ch;
	cin>>ch;
	if(ch=='+'||ch=='-'||ch=='*'||ch=='/'||ch=='%')
	{
		long long int n1,n2,n3;
		cin>>n1>>n2;
		if(ch=='+')
		n3=n1+n2;
		else if(ch=='-')
		n3=n1-n2;
		else if(ch=='*')
		n3 = n1*n2;
		else if(ch=='/')
		{
			if(n2==0)
			break;
			else
			n3 = n1/n2;
		}
		else if(ch=='%')
		{
			if(n2==0)
			break;
			else
			n3 = n1%n2;
		}
      cout<<n3<<endl;
	}
	else if(ch=='X'||ch=='x')
	break;

	else
	{
		cout<<"Invalid operation. Try again."<<endl;
		continue;
	}
}
return 0;

}

You must be thinking, why am i sending the same code to you.
yes , it is the same code but with a minute modification.
moreover, this code is passing all the test cases.
Can you find the difference?

cout<<“Invalid operation. Try again.”<<endl;

please, read the question properly before attempting it.
You have applied the correct logic but the way you are producing output is incorrect.

don’t worry, these are the silly mistakes everyone does. Practice is the only solution to eliminate them.
Keep practicing :slightly_smiling_face:

hope this would help.
if you still have doubts, feel free to ask.

1 Like
#3

mark the doubt as resolved if you are satisfied with my answer.
if possible, give a like and review about me.
:wink:

1 Like
#4

thankyou :slight_smile:

#5


sir this code is still not passing some test cases

#6

Can you run the code I have modified.
Let me know, if it is not passing the test cases.

Actually, I don’t have my lapi with me right now n it very difficult to handle the ide on mobile.

If it runs well, check for the difference.
Else, I’ll resolve your doubt before 11 am.

#7

sir it is not working :sweat_smile:

#8

I’ll manage a lapi and will resolve it by today. Apologies for the delay.
N m sorry, I acknowledged ur other post too. :sweat_smile:

#9

again, i repeat. Please, read the question properly.
There is a set format of outputs in question.
so, follow them

btw your mistake is a full stop “.”
you are printing:
“Invalid operation. Try again”

and you are required to print:
“Invalid operation. Try again.”

Here’s your solution.
Hope, this would help.

1 Like
#10

oh okay thanks :slight_smile: