Base case is wrong for n==0. it will display stackoverflow

#1

function will execute infinite time and stackoverflow occur,
base case must be if(n==0||n==1) return 1;

#2

Hey @Vipin_coder
base case :
if(n==0) {
return n;
}
fact is always 0
if(n==0||n==1) return n; // No need
simple use
if(n==1) return n;

#3

Thank you so much sir

#4

Please mark your doubts as resolved in your course’s.

#6

@Vipin_coder
if(n==0||n==1) return 1 , its true
Yes
(n==0 )// these are Extra Condition No need

#7

but you told, if (n==0) return n , fact is always 0, how it can be happened.:grinning:

#8

@Vipin_coder
public static int fact(int n) {
if(n==0) {
return n;
}
return n*fact(n-1);
}
this is a fac function
retutn n * fact(n-1); // base case se 0 aaya
n *0 its 0
I would suggest you Make call Stack .

#9

but factorial of zero must be 1, not 0

#10

your base case is wrong

#11

if is n == 0 , you return 1.its is correct

#12

A/c this base Case its give Zero

#13

yes but your base case will return 0 for 0 , and the base case in lecture is if(n==1) return 1, when i will put n==0, then stackoverflow will occur

#14

Yes this code is wrong.
I have responded this Question
you told, if (n==0) return n , fact is always 0, how it can be happened.

#15

@Vipin_coder Send me your code

#16

i mean (n==0||n==1) return 1, but you said fact is always 0 for 0.

#17

@Vipin_coder
Nope
this base case is right
(n==0 )// these are Extra Condition No need

#18

you mean for n=0 , factorial is 0.

#19

@Vipin_coder nope
simple use
if(n==1)
return n
bs

#20

ok , but when i will enter 0 for n then stack overflow will occur , so this base case is wrong

#21

Mai 0 pe nhi jaaunga.
n always n-1 ho raha h
pehle base case n==1 yaha se return kr jayenge 1
0 wala case kabhi nhi aayega