why is it not accepting testcases
💡 Balanced Parenthesis
Hey @17manishms
You’re writing the code for only ‘(’ , ‘)’ brackets, the input string can consist of ‘[’, ‘]’, ‘{’, ‘}’ also. So consider these as well in your code.
Also don’t print your final ans in between the for loop, this can print yes/ no multiple times. for example in ()), it will print NoYes in this case as your ans.
So a good way to handle this is maintaining a bool ans variable, and updating it whenever you get the ans as true or false, and printing the final ans as yes or no at the end.
#include
#include
#include
using namespace std;
int main() {
string str;
bool ans=true;
stack s;
getline(cin,str);
int i=0;
while(str.length()>i)
{
if(str[i]==’(’||str[i]==’{’||str[i]==’[’)
{
s.push(str[i]);
}
else if(str[i]==’)’|| str[i]==’}’||str[i]==’]’)
{
if(s.empty())
{
ans=false;
}
else{
s.pop();
}
}
i++;
}
if(s.empty() && ans)
{
cout<<“Yes”;
}
else{
cout<<“No”;
}
return 0;
}
again it is not accepting all the testcases
else if(str[i]==’)’|| str[i]==’}’||str[i]==’]’)
{
if(s.empty())
{
ans=false;
}
else{
s.pop();
}
}
The above part of your code is wrong. ‘(’ will be popped only by ‘)’. ‘{’ by ‘}’ only and ‘[’ by ‘]’. so you need to write separate cases for ‘)’, ‘}’ and ‘]’. like:-
else if(str[i]==’)’)
{
if(s.empty())
{
ans=false;
}
else if(str[i] == ‘(’){
s.pop();
}
else{
ans = false;
}
}
similarly you need to write for } and ].
I hope I’ve cleared your doubt. I ask you to please rate your experience here
Your feedback is very important. It helps us improve our platform and hence provide you
the learning experience you deserve.
On the off chance, you still have some questions or not find the answers satisfactory, you may reopen
the doubt.