What is the problem in this code?

#1
#2

hello @Ak07
image
use slow ->next!=fast->next;
because we need to stop one node before the cycle
so that we can simply do fast->next=NULL to remove cycle.
while loop after this condtion is redundant u can remove that.

#3

also try to submit ur code here.
https://hack.codingblocks.com/app/contests/1350/1307/problem
because input / output is already handled ,u just need to write code for cycle detection and removal

#4

That is ok but then what do I do for this problem which is in the course

#5

you can submit there as well

#6

on hackerblocks it passed all cases, but in course it is not,
also I guess they are two different problems altogether

#7

have u submitted same code at both places?

#8

yes, exactly same code

#9

please share ur updated code using cb ide ,i will check

#10
#11

check this->

you were not reading input completely.
image
here dont return read till end.
so replace return with continue

#12

I didn’t write this input function it was already written, but as you suggested that in hackerblocks the input output is already handled I just wrote for cycle detection and removal. I didn’t understand this input function as I have not studied hash. Hence I had started by writing my own build function, if possible can you please guide me for this problem on the code that I wrote on my own from scratch

#13

see basically u are searching whether the entered number is already existing in list or not , if it is then u are making a cycle otherwise u r adding it to the tail.

same thing is happening in the previous code .instead of searching we have stored the information in map.
so that we dont have to search again n again.

due to so many search operations ur code might give tle.
but logically ur code is correct ( after making changes that i have suggested very first time).

#14

Thanks a lot, but it is still only passing 1/3 test cases

#15

r u sure ,
in my machine it is passing all
image

#16
#17

sorry, my bad, yes its passing all 3, Thanks