Unable to find the error

#1

i am unable to find the error in this code

#2

check updated code: https://ide.codingblocks.com/s/210502

the error was in substr() function , read about this function from cpp official site.

thanks