String split program error

#1

I had written this code string splitting.However,its not working.I’m not able to figure out the mistake here actually.

#2