Pls tell me whats wrong in the code

#1

whats wrong in the code its not working…is my approch fine??

#2

Please look the problem once!!