Please help me rectify the code,what is wrong in the code

i think cin>>s is also important

i have marked what wrong in ur code and rectify it check this if any problem reply