Not getting corect output

#1 
#include <iostream>
#include <algorithm>
#include <climits>
using namespace std;
bool isvalid(int a[], int n, int c, int mid)
{
    int total_prata = 0;
    for (int i = 0; i < c; i++)
    {
        int time = 0;
        int count = 1;
        while (time <= mid)
        {
            time += a[i] * count;
            total_prata += count;
            count++;
        }
    }
    return total_prata >= n;
}
int main()
{
    int t;
    cin >> t;
    int n, c;
    while (t--)
    {
        cin >> n;
        cin >> c;
        int a[c];
        for (int i = 0; i < c; i++)
        {
            cin >> a[i];
        }
        sort(a, a + c);
        int start = 0;
        int end = 0;
        for (int i = 1; i <= n; i++)
        {
            end += a[0] * i;
        }
        int ans = INT_MAX;
        while (start < end)
        {
            int mid = (start + end) / 2;
            if (isvalid(a, n, c, mid))
            {
                ans = min(ans, mid);
                end = mid - 1;
            }
            else
            {
                start = mid + 1;
            }
        }
        cout << ans << endl;
    }

    return 0;
}
#2

hey are you there???

#3

yes your is valid function is not correct

look at this code

correct code

#4

your code is okay… but why my logic is not working??
also in your code int e=8*(§*(P+1))/2; how can you calculate the end with sum of n terms formula? if the rank of the cook is 8 the series of time in which he will cook the ith prata will be 8multiply1,8multiply2,8multiply3,8multiply4…8multiplyn ; thus it forms Arithmetic progression

#5

i have consider the worst case for finding e
your way is also correct for find end

#6

what is wrong in this???

#7

@asaurabh_26 please reply brother i have been struck on this very long ?

#8

Your mistakes

  1. don’t sort the array
  2. start should be 1 because min time require to make P pratas can be 1
  3. in while loop condition start<=end (you forgot = condition)
  4. total_prata should increased by 1 not by count
  5. you have to increase prata only when time<=mid

Modified Code

now it got accepted
i hope this help
if you have any further doubts
feel free to ask
and don’t forgot to mark doubt as resolved

#9

i sorted the array because to calculate end i will need the fastest cook rank in the array to calculate end

#10

thanks @asaurabh_26 :slight_smile:

#11

If your doubt is resolved, plz mark it as resolved from your side .

#12

I hope I’ve cleared your doubt. I ask you to please rate your experience here
Your feedback is very important. It helps us improve our platform and hence provide you
the learning experience you deserve.

On the off chance, you still have some questions or not find the answers satisfactory, you may reopen
the doubt.