Circular Linked List question in java

justformyntra8 · May 25, 2019, 8:36am

im getting a timed out error , for this code, kindly help me identify the mistake.

bhardwaj-aman/java-data-structures-practice-questions/blob/master/RemoveloopinlinkedList

import java.util.Scanner;

public class LinkedList {
    private class Node {
        int data;
        Node next;

        Node(int data, Node next) {
            this.data = data;
            this.next = next;
        }
    }

    private Node head;
    private Node tail;
    private int size;

    public LinkedList() {
        this.head = null;
        this.tail = null;

This file has been truncated. show original

Riyabansal98 · May 25, 2019, 1:18pm

Hi Aman
Your code doesn’t work for the case 1 -1. The output should 1 in this case. Your code gives null pointer exception.

Also, there is no need to take input in a string. You can take input normally in the form of integers.

Riyabansal98 · May 25, 2019, 1:18pm


int a;

do {

a = scn.nextInt();

l.addLast(a);
} while (a != -1);

justformyntra8 · May 25, 2019, 4:34pm

yes i made the change, but it is still showing timed-out for 2 test cases

Riyabansal98 · May 26, 2019, 6:26am

Hi @justformyntra8

Can you share the link to your modified code? I’ll have a look once.

Riyabansal98 · May 31, 2019, 6:01am

Hi Aman
As you are not responding to this thread, I am marking your doubt as Resolved for now. Re-open it if required.
Please mark your doubts as resolved in your course’s “ Ask Doubt ” section, when your doubt is resolved.

Riyabansal98 · May 31, 2019, 6:01am

I hope I’ve cleared your doubt. I ask you to please rate your experience here
Your feedback is very important. It helps us improve our platform and hence provide you
the learning experience you deserve.

On the off chance, you still have some questions or not find the answers satisfactory, you may reopen
the doubt.

justformyntra8 · June 6, 2019, 4:28pm

github.com

bhardwaj-aman/java-data-structures-practice-questions/blob/master/(*)CircularLinkedList

import java.util.Scanner;

public class LinkedList {
    private class Node {
        int data;
        Node next;

        Node(int data, Node next) {
            this.data = data;
            this.next = next;
        }
    }

    private Node head;
    private Node tail;
    private int size;

    public LinkedList() {
        this.head = null;
        this.tail = null;

This file has been truncated. show original

justformyntra8 · June 6, 2019, 4:31pm

I have shared the updated code- please let me know where I am mistaken

Riyabansal98 · June 8, 2019, 5:43am

Hi @justformyntra8

The complexity of the question is very high. That is why you are getting Time Limit Exceeded error.
Try implementing a different approach.

Riyabansal98 · June 12, 2019, 12:36pm

Hi @justformyntra8

As you are not responding to the thread, I am marking your doubt as resolved for now. Re-open it if required.
Please mark your doubt as resolved in your course’s “Ask Doubt” section, when your doubt is resolved.

Riyabansal98 · June 12, 2019, 12:36pm

I hope I’ve cleared your doubt. I ask you to please rate your experience here
Your feedback is very important. It helps us improve our platform and hence provide you
the learning experience you deserve.

On the off chance, you still have some questions or not find the answers satisfactory, you may reopen
the doubt.